Compiling libgit2 with libssh2 for iOS #250
Conversation
|
One last dependency - libtool: git://git.savannah.gnu.org/libtool.git |
|
Dependencies that must be built for iOS should happen in ObjectiveGit's build process. Dependencies that are built for OS X, and simply needed to build, should be installed via Homebrew and documented in the README. |
|
@jspahrsummers - ok that makes more sense than including everything as submodules :) Does that commit look ok? |
|
|
||
| To compile [libgit2] with [libssh2] you need to install the following dependencies via [Homebrew]: | ||
|
|
||
| Mac OS X: `$ brew install libssh2` |
There was a problem hiding this comment.
I don't think this is true when building for OS X, since there's already a prebuilt OpenSSL that we can link against.
There was a problem hiding this comment.
@jspahrsummers - are you sure about this? I couldn't find libssh2 on Mac OS X 10.8.4 - I had to install it via homebrew to get it to work with script/update_libgit2
There was a problem hiding this comment.
Ah, I was thinking of OpenSSL. I guess this is a different thing. :\
|
The lack of indentation in this shell script makes it really hard to read. Can you please fix that? Also, we're starting to get a lot of noise in the repository's top-level folder. Can we move all the dependencies into an "External" folder? |
|
@jspahrsummers - just to clarify - you want to move all the dependencies (including submodules libgit2, openssl etc...) into a new External folder? (I presume you mean a new folder on the file system and not just a folder/group in Xcode) |
|
Correct. The on-disk structure is the first thing that people see when viewing objective-git on GitHub. We should keep it clean. |
|
@jspahrsummers - I think that is everything - let me know if it looks ok. |
ghost
assigned
|
Thanks! This change looks good, but I'm working on getting the dependencies correctly installed in our CI setup before merging this. |
Compiling libgit2 with libssh2 for iOS
Compiling libgit2 with libssh2 for iOS
I've got this working but it does introduce some more dependencies:
Should I go ahead and open a pull request that includes these dependencies as submodules?